Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach with for of in test-buffer-slice.js #49785

Merged
merged 1 commit into from
Nov 10, 2023
Merged

test: replace forEach with for of in test-buffer-slice.js #49785

merged 1 commit into from
Nov 10, 2023

Conversation

CorrWu
Copy link
Contributor

@CorrWu CorrWu commented Sep 22, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 22, 2023
tniessen
tniessen reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @CorrWu. According to our commit message guidelines, the commit message should begin with test: replace .... You can follow these instructions to change the commit message.

@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 22, 2023
@CorrWu CorrWu changed the title Replace forEach with for of in test-buffer-slice.js test: replace forEach with for of in test-buffer-slice.js Sep 23, 2023
@CorrWu
Copy link
Contributor Author

CorrWu commented Sep 23, 2023

Just fixed it. Is it good now?

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54233/

@github-actions github-actions bot mentioned this pull request Sep 28, 2023
Open
19 tasks
@debadree25 debadree25 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55151/

This was referenced Oct 24, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55428/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55476/

@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit a5a6fef into nodejs:main Nov 10, 2023
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a5a6fef

targos pushed a commit that referenced this pull request Nov 11, 2023
@CorrWu @targos
test: replace forEach with for of
96907b5 
PR-URL: #49785
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@CorrWu @targos
test: replace forEach with for of
1d52a57 
PR-URL: #49785
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@CorrWu @UlisesGascon
test: replace forEach with for of
03ba28f 
PR-URL: #49785
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CorrWu @nodejs-github-bot @jasnell @lpinca @tniessen @debadree25